Glasgow | Mansoor Munawar | Structuring and Testing Data | Sprint 3 #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 17, 2025
| if (Math.abs(numerator) < Math.abs(denominator)) return true; | ||
| else if (numerator === denominator) return false; | ||
| else if (numerator > denominator) return false; | ||
| else return false; | ||
| } |
There was a problem hiding this comment.
Can you see any way you could combine these 3 return false conditions into one line?
| // Handle Ace (A): | ||
| // Given a card with a rank of "A", | ||
| // When the function is called with an Ace, | ||
| // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack. | ||
|
|
||
| const aceOfHearts = getCardValue("A♥"); | ||
| assertEquals(aceOfSpades, 11); |
There was a problem hiding this comment.
I think you may have made a typo here that invalidates this test. Which variables are you trying to test for on this line?
There was a problem hiding this comment.
Thanks for the feedback. I've now made the requested changes.
LonMcGregor
added
Reviewed
MansoorM11
added
Needs Review
|
Good work on this sprint - you can close this and move to the next one |
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
I have completed the task for sprint 3 which required me to create test using Jest and implement functions to solve the required problems.
Questions
Ask any questions you have for your reviewer.